Fix credential validation if no metrics given #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no metrics credentials are given the metrics_server is "" not nil. This was causing it to continue past the `return true unless server` line and fail later on. This checks if the metrics_server is `.blank?` which will catch nil as well as "".
|
Checked commit agrare@7fed90d with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@jhernand can you please review? |
jhernand
approved these changes
Nov 10, 2017
simaishi
pushed a commit
that referenced
this pull request
Nov 14, 2017
…metrics Fix credential validation if no metrics given (cherry picked from commit 0a05dcd) https://bugzilla.redhat.com/show_bug.cgi?id=1511079
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no metrics credentials are given the metrics_server is "" not nil.
This was causing it to continue past the
return true unless serverline and fail later on.
This checks if the metrics_server is
.blank?which will catch nil aswell as "".
Introduced by #134