upgrade ovirt to 4.6 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot cross_repo_test #54 including ManageIQ/ovirt#118 |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Sep 10, 2024
From Pull Request: ManageIQ/manageiq-providers-red_hat_virtualization#54
Fryguy
reviewed
Sep 10, 2024
Comment on lines
22
to
23
| spec.add_dependency "ovirt-engine-sdk", "~>4.6.0" | ||
| spec.add_dependency "ovirt_metrics", "~>3.2" |
There was a problem hiding this comment.
As discussed in the other thread, I wonder if it's cleaner / better to do the following
Suggested change
| spec.add_dependency "ovirt-engine-sdk", "~>4.6.0" | |
| spec.add_dependency "ovirt_metrics", "~>3.2" | |
| spec.add_dependency "manageiq-providers-ovirt" |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Sep 10, 2024
From Pull Request: ManageIQ/manageiq-providers-red_hat_virtualization#54
kbrock
force-pushed
the
update-ovirt
branch
from
bf0d539
to
9dc9ade
Compare
|
update:
|
|
LGTM - just want @agrare to also see this before merge. If we agree on this approach we'll want to do the same in the other inherited gems. |
Fryguy
approved these changes
Sep 10, 2024
agrare
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating gem because it fixes some issues with ruby 3.3 building
Gem released Feb 1, 2024