[WIP] Add VM Networks to collected information

[djberg96]

Currently we collect logical networks, but we do not collect VM network information. This PR adds support for them by adding them to the guest_devices table.

Each VM network is associated with a lan (logical network), and so I add that relationship as well. We should then be able to get to the switch (virtual network) via the lan.

Ideally we should create a relationship between a VM and its corresponding VM networks.

Some more information here:

http://windowsitpro.com/hyper-v/understanding-hyper-v-networking-system-center-vmm-2012-r2

[bronaghs]

Hi @agrare
My understanding is that the Powershell changes in this PR are final but the parser will need updated to reflect the schema changes here
It doesn't look like the inventory YML file used for specs has been updated, does this block you from taking this over while Dan is out?

[agrare]

@bronaghs I'll see what I can do with the scvmm provider I have access to.

[miq-bot]

Checked commits https://github.com/djberg96/manageiq-providers-scvmm/compare/8c97f1605d8fdfe7e0b78803256d9c531bb5ac17~...a6dd1a06ceaf24c8a91da95a97c8cc4422f3e61f with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 2 offenses detected

app/models/manageiq/providers/microsoft/infra_manager/refresh_parser.rb

• ❗ - Line 130, Col 7 - Style/RedundantReturn - Redundant return detected.
• ❗ - Line 90, Col 9 - Style/AccessorMethodName - Do not prefix reader method names with get_.

[djberg96]

@bronaghs @agrare I've updated this WIP to reflect the changes. I think this will do the trick, but I need to update save_inventory.

[agrare]

Hey @djberg96 didn't know you'd be back working already :) Just for reference I started taking a crack at this here #19

Since the VMNetworks are children of a switch I think we want these to be under the switch instead of a top level collection.

I'll take care of the save_inventory side.

[djberg96]

@agrare Maybe I'm not sure how you want to represent a VM network, but it should be a child of a logical network (lan) shouldn't it?

[agrare]

@djberg96 try with ManageIQ/manageiq#16153 that should save the subnets for you

[agrare]

Maybe I'm not sure how you want to represent a VM network, but it should be a child of a logical network (lan) shouldn't it?

Right that's why we added the parent_id to Lan, so the vm_networks will also be in switch -> lans but will have a parent_id

[agrare]

@djberg96 the changes to manageiq core are in to save subnets so you should be good there
I stole your subnet parser for https://github.com/ManageIQ/manageiq-providers-scvmm/pull/19/files#diff-70f4237341291be1403b3349c4fbafb7R215 so that works now, you can use it or ignore it :D up to you

I still need to do the lan parent_id saving, that'll be a little trickier.

[djberg96]

Closed in favor of #19