Skip to content
This repository has been archived by the owner on Jul 25, 2023. It is now read-only.

Graph refresh for SCVMM #81

Merged
merged 14 commits into from
Aug 30, 2018
Merged

Graph refresh for SCVMM #81

merged 14 commits into from
Aug 30, 2018

Conversation

agrare
Copy link
Member

@agrare agrare commented Aug 8, 2018

Implement Graph Refresh for SCVMM provider

@miq-bot miq-bot added the wip label Aug 8, 2018
@agrare agrare force-pushed the scvmm_graph_refresh branch 5 times, most recently from c79ab6a to d95d6f4 Compare August 9, 2018 18:42
@agrare agrare changed the title [WIP] Graph refresh for SCVMM Graph refresh for SCVMM Aug 30, 2018
@agrare agrare added enhancement and removed wip labels Aug 30, 2018
@miq-bot
Copy link
Member

miq-bot commented Aug 30, 2018

Checked commits agrare/manageiq-providers-scvmm@049e1b8~...79c1486 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
10 files checked, 1 offense detected

app/models/manageiq/providers/microsoft/infra_manager/parser_mixin.rb

  • ❗ - Line 90, Col 8 - Style/SafeNavigation - Use safe navigation (&.) instead of checking if an object exists before calling the method.

@@ -0,0 +1,31 @@
class ManageIQ::Providers::Microsoft::Inventory::Persister::InfraManager < ManageIQ::Providers::Microsoft::Inventory::Persister
def initialize_inventory_collections
add_infra_collection(:disks)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the list of symbols will be probably nicer?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this is great

@Ladas Ladas merged commit 7f8ed1b into ManageIQ:master Aug 30, 2018
@Ladas Ladas added this to the Sprint 94 Ending Sept 10, 2018 milestone Aug 30, 2018
@agrare agrare deleted the scvmm_graph_refresh branch August 30, 2018 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants