Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue where dvs_ prefix is removed from :vlan in provision's options hash. #100

Merged
merged 1 commit into from
Aug 17, 2017

Conversation

lfu
Copy link
Member

@lfu lfu commented Aug 17, 2017

Fix the VM Provisioning issue with auto replacement in selected dvPortGroup network.
Issue was introduced in #78.

https://bugzilla.redhat.com/show_bug.cgi?id=1482270

@miq-bot assign @agrare
@miq-bot add_label bug, fine/yes

@miq-bot
Copy link
Member

miq-bot commented Aug 17, 2017

Checked commit lfu@3032d51 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great find @lfu
Another reason to get away from the dvs_ prefix completely :)

Will merge when green

@agrare agrare merged commit 3032d51 into ManageIQ:master Aug 17, 2017
agrare added a commit that referenced this pull request Aug 17, 2017
Fix the issue where dvs_ prefix is removed from :vlan in provision's options hash.
@agrare agrare added this to the Sprint 67 Ending Aug 21, 2017 milestone Aug 17, 2017
simaishi pushed a commit that referenced this pull request Aug 17, 2017
Fix the issue where dvs_ prefix is removed from :vlan in provision's options hash.
(cherry picked from commit fd7d33a)

https://bugzilla.redhat.com/show_bug.cgi?id=1482668
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 58e20bf9862e9c0de59c23ae4c85cea59de8918a
Author: Adam Grare <agrare@redhat.com>
Date:   Wed Aug 16 21:45:29 2017 -0400

    Merge pull request #100 from lfu/set_host_1482270
    
    Fix the issue where dvs_ prefix is removed from :vlan in provision's options hash.
    (cherry picked from commit fd7d33ab462534b86529aae1d6e005997c34eee6)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1482668

@lfu lfu deleted the set_host_1482270 branch September 29, 2018 14:35
agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
…geted_refresh

Remove createfolder event handler since it is now handled by MiqVimBrokerWorker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants