Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix storage location parsing for update collector #135

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Fix storage location parsing for update collector #135

merged 1 commit into from
Nov 13, 2017

Conversation

agrare
Copy link
Member

@agrare agrare commented Nov 12, 2017

Fix an issue where the storage location is parsed as "" causing creating
of the storage records to fail.

@agrare
Fix storage location parsing for update collector
21cfa88 
Fix an issue where the storage location is parsed as "" causing creating
of the storage records to fail.
@agrare agrare added the bug label Nov 12, 2017
agrare
agrare commented Nov 12, 2017
View reviewed changes
app/models/manageiq/providers/vmware/infra_manager/inventory/parser/datastore.rb
# NFS on ESX has the path in the datastore instead:
# 192.168.254.80:/shares/public
datastore = inv["summary.datastore"].to_s.downcase
return datastore.gsub(':/', '/') if datastore =~ /^[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESXi has a half guid in the url also so this isn't needed

@agrare agrare requested a review from Ladas November 13, 2017 13:45
@agrare
Copy link
Member Author

agrare commented Nov 13, 2017

This should fix travis for this repo

Ladas
Ladas approved these changes Nov 13, 2017
View reviewed changes
Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, fixes CI

@Ladas Ladas merged commit 39f13af into ManageIQ:master Nov 13, 2017
@Ladas Ladas added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 13, 2017
@agrare agrare deleted the fix_storage_location_parsing branch November 13, 2017 13:50
@agrare
Copy link
Member Author

agrare commented Nov 13, 2017

Marking for G-release because ManageIQ/manageiq#16408 is going to be backported

@agrare agrare mentioned this pull request Nov 13, 2017
Merged
simaishi pushed a commit that referenced this pull request Nov 15, 2017
@Ladas @simaishi
Merge pull request #135 from agrare/fix_storage_location_parsing
3b785e2 
Fix storage location parsing for update collector
(cherry picked from commit 39f13af)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 3b785e25da132a74b6a126c1196a3e618b80f5c9
Author: Ladislav Smola <lsmola@redhat.com>
Date:   Mon Nov 13 14:50:19 2017 +0100

    Merge pull request #135 from agrare/fix_storage_location_parsing
    
    Fix storage location parsing for update collector
    (cherry picked from commit 39f13af9618a74c5dc2a18cdb036f618cf347bdc)

agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
@mkanoor
Merge pull request ManageIQ#135 from billfitzgerald0120/check_migrate
61793a6 
Updated vm migration to report when an error occurs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladas Ladas Ladas approved these changes

Assignees

@Ladas Ladas

Labels
bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agrare @simaishi @Ladas