Inventory host serial number #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_labels enhancement |
|
👍 confirmed this works. I released a new version of vmware_web_service (v0.2.3) can you require this in the gemspec? |
|
Checked commit https://github.com/jameswnl/manageiq-providers-vmware/commit/d093212743c1908b74c37fbe8e756a113e49ee2d with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
jameswnl
commented
Nov 17, 2017
| @@ -14,7 +14,7 @@ Gem::Specification.new do |s| | |||
| s.files = Dir["{app,config,lib}/**/*"] | |||
|
|
|||
| s.add_dependency("fog-vcloud-director", ["~> 0.1.8"]) | |||
| s.add_dependency "vmware_web_service", "~>0.2.0" | |||
| s.add_dependency "vmware_web_service", "~>0.2.3" | |||
There was a problem hiding this comment.
@agrare here you go....
agrare
approved these changes
Nov 17, 2017
|
@simaishi this is needed for ManageIQ/manageiq-providers-lenovo#93 |
simaishi
pushed a commit
that referenced
this pull request
Nov 20, 2017
Inventory host serial number (cherry picked from commit ead619e)
|
Gaprindashvili backport details: |
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
v2v: Fix list drivers on missing ISO domain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ManageIQ/vmware_web_service#24