Fix broken specs from EMS hostname validation and vCloud Refresh #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManageIQ/manageiq#16714 Caused the specs which use invalid hostnames to fail in different ways then expected. The test checking for nil ems hostname is now invalid because that isn't possible and the other changed the hostname to something with a space which can be replaced with a '-'
|
@blomquisg @Fryguy this fixes the two failing InfraManager specs, still looking into the NetworkManager VCR failure |
Fog-core 2.0 is getting pulled in by fog-openstack which is causing the vcr spec tests for vCloud director to fail.
agrare
changed the title
|
Checked commits agrare/manageiq-providers-vmware@621a19f~...ff7081c with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Jan 15, 2018
Fix broken specs from EMS hostname validation and vCloud Refresh (cherry picked from commit e017119)
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Jan 15, 2018
Fix broken specs from EMS hostname validation and vCloud Refresh (cherry picked from commit e017119)
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two different classes of spec failures which cropped up over the past week
Hostname Validation
Adding hostname format validation manageiq#16714 Caused the specs which
use invalid hostnames to fail in different ways then expected. The test
checking for nil ems hostname is now invalid because that isn't possible
and the other changed the hostname to something with a space which can
be replaced with a '-'
fog-core2.0 causing vCloud VCR failuresfog-core 2.0 was released and fog-openstack was pulling in
fog-core >= 1.40. This ended up pulling in 2.0 which was breaking these VCR tests. @Ladas fixed this in fog-openstack here but that version can't be used until it is tested further.