Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to pick administrator password upon vApp provisioning #196

Merged
merged 1 commit into from
Feb 28, 2018

Conversation

miha-plesko
Copy link
Contributor

@miha-plesko miha-plesko commented Feb 28, 2018

With this commit we add yet another two fields to the vApp provisioning Service Dialog: admin_password (text input) and admin_reset (checkbox) for each VM to allow for administrator password customization.

Passoword is displayed in plaintext, because this is also the case on vCloud dashboard, so it makes no sense to hide it here.

capture

capture

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1550909

@miq-bot add_label enhancement,gaprindashvili/yes
@miq-bot assign @agrare

With this commit we add yet another two fields to the vApp provisioning
Service Dialog: admin_password (text input) and admin_reset (checkbox)
for each VM to allow for administrator password customization.

Passoword is displayed in plaintext, because this is also the case on vCloud
dashboard, so it makes no sense to hide it here.

Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
@miq-bot
Copy link
Member

miq-bot commented Feb 28, 2018

Checked commit miha-plesko@7fdea10 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 0 offenses detected
Everything looks fine. 🍪

Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice @miha-plesko

@agrare agrare merged commit 7fdea10 into ManageIQ:master Feb 28, 2018
agrare added a commit that referenced this pull request Feb 28, 2018
Allow user to pick administrator password upon vApp provisioning
@agrare agrare added this to the Sprint 81 Ending Mar 12, 2018 milestone Feb 28, 2018
@miha-plesko
Copy link
Contributor Author

simaishi pushed a commit that referenced this pull request Mar 7, 2018
Allow user to pick administrator password upon vApp provisioning
(cherry picked from commit afe46d2)

https://bugzilla.redhat.com/show_bug.cgi?id=1552842
@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2018

Gaprindashvili backport details:

$ git log -1
commit 614f39cd1a793253e69ead84f4e8842bbe4f5a55
Author: Adam Grare <agrare@redhat.com>
Date:   Wed Feb 28 11:06:11 2018 -0500

    Merge pull request #196 from miha-plesko/vapp-provision-admin-pass
    
    Allow user to pick administrator password upon vApp provisioning
    (cherry picked from commit afe46d25770204246188bbcc0f487975925db75b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1552842

@miha-plesko miha-plesko deleted the vapp-provision-admin-pass branch January 7, 2019 08:25
agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
…ve_provisions

Added active provisions to quota count.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants