-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to pick administrator password upon vApp provisioning #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we add yet another two fields to the vApp provisioning Service Dialog: admin_password (text input) and admin_reset (checkbox) for each VM to allow for administrator password customization. Passoword is displayed in plaintext, because this is also the case on vCloud dashboard, so it makes no sense to hide it here. Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
Checked commit miha-plesko@7fdea10 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Feb 28, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 nice @miha-plesko
agrare
added a commit
that referenced
this pull request
Feb 28, 2018
Allow user to pick administrator password upon vApp provisioning
simaishi
pushed a commit
that referenced
this pull request
Mar 7, 2018
Allow user to pick administrator password upon vApp provisioning (cherry picked from commit afe46d2) https://bugzilla.redhat.com/show_bug.cgi?id=1552842
Gaprindashvili backport details:
|
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
…ve_provisions Added active provisions to quota count.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we add yet another two fields to the vApp provisioning Service Dialog: admin_password (text input) and admin_reset (checkbox) for each VM to allow for administrator password customization.
Passoword is displayed in plaintext, because this is also the case on vCloud dashboard, so it makes no sense to hide it here.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1550909
@miq-bot add_label enhancement,gaprindashvili/yes
@miq-bot assign @agrare