Completely stop/suspend VM, not just partially #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @miha-plesko |
|
before: |
miha-plesko
suggested changes
Mar 5, 2018
There was a problem hiding this comment.
@sasoc thanks for this awesome PR, I only have two cosmetic comments, otherwise looks really good.
| context '.raw_stop' do | ||
| it 'stops the virtual machine' do | ||
| expect(connection).to receive(:post_undeploy_vapp).with('id', :UndeployPowerAction => 'powerOff').and_return(response) | ||
| expect(connection).to receive(:process_task).and_return(true) |
There was a problem hiding this comment.
You don't really need the .and_return(true) part, please feel free to remove it (also below, for suspend).
| let(:ems) { FactoryGirl.create(:ems_vmware_cloud) } | ||
| let(:vm) { FactoryGirl.create(:vm_vcloud, :ext_management_system => ems, :ems_ref => 'id') } | ||
| let(:connection) { double('connection') } | ||
| let(:response) { double('response', :body => nil) } |
There was a problem hiding this comment.
Nitpicking, but can you please vertically align {. I know that Rubocop says nothing, but still it's prettier.
If you stop/suspend VM in vCloud Director UI, it stops/suspends completely. But when calling same action using vCloud API it only stops/suspends VM partially, that is because it stays in `deployed` state. To reach the same effect as in vCloud Director UI we now use`post_undeploy_vapp` with `UndeployPowerAction'` set to `'powerOff'`/`'suspend'` Signed-off-by: sasoc <saso.cvitkovic@gmail.com>
sasoc
force-pushed
the
completely-stop-or-suspend-vm
branch
from
acde81f
to
4c60f14
Compare
|
Checked commit sasoc@4c60f14 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Mar 8, 2018
simaishi
pushed a commit
that referenced
this pull request
Mar 8, 2018
Completely stop/suspend VM, not just partially (cherry picked from commit 30e5ad2) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553389
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you stop/suspend VM in vCloud Director UI, it stops/suspends completely. But when calling same action using vCloud API it only stops/suspends VM partially, that is because it stays in
deployedstate. To reach the same effect as in vCloud Director UI we now usepost_undeploy_vappwith'UndeployPowerAction'set to'powerOff'/'suspend'Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1551534