Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WebMKS/VNC console access #211

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Fix WebMKS/VNC console access #211

merged 1 commit into from
Mar 16, 2018

Conversation

bmclaughlin
Copy link
Contributor

A recent VMRC authentication enhancement was inadvertently required for the other VMware supported consoles.

@miq-bot add_labels bug

https://bugzilla.redhat.com/show_bug.cgi?id=1557387

@miq-bot miq-bot added the bug label Mar 16, 2018
@agrare agrare self-assigned this Mar 16, 2018
@agrare
Copy link
Member

agrare commented Mar 16, 2018

@skateman can you review/confirm this is just vmrc that needs credentials?

@miq-bot
Copy link
Member

miq-bot commented Mar 16, 2018

Checked commit bmclaughlin@ae8c2eb with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@skateman
Copy link
Member

@agrare yes, only VMRC needs these credentials

@agrare agrare merged commit d4656e6 into ManageIQ:master Mar 16, 2018
@agrare agrare added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 16, 2018
@bmclaughlin bmclaughlin deleted the fix-console-access-failures branch March 16, 2018 19:32
@bmclaughlin
Copy link
Contributor Author

@miq-bot add_labels fine/yes, gaprindashvili/yes

simaishi pushed a commit that referenced this pull request Mar 19, 2018
@agrare @simaishi
Merge pull request #211 from bmclaughlin/fix-console-access-failures
c0f01cb 
Fix WebMKS/VNC console access
(cherry picked from commit d4656e6)

https://bugzilla.redhat.com/show_bug.cgi?id=1558075
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit c0f01cb6c6d73c2f58ae0559bffb6b5105ffb328
Author: Adam Grare <agrare@redhat.com>
Date:   Fri Mar 16 15:18:45 2018 -0400

    Merge pull request #211 from bmclaughlin/fix-console-access-failures
    
    Fix WebMKS/VNC console access
    (cherry picked from commit d4656e696cd3e4d1e599302e08e4055610386ffc)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1558075

@JPrause
Copy link
Member

JPrause commented Apr 10, 2018

@miq-bot add_label blocker

simaishi pushed a commit that referenced this pull request Apr 10, 2018
@agrare @simaishi
Merge pull request #211 from bmclaughlin/fix-console-access-failures
6be7398 
Fix WebMKS/VNC console access
(cherry picked from commit d4656e6)

https://bugzilla.redhat.com/show_bug.cgi?id=1558076
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 6be73980ae72b025ae17f5f8a93c92fea4106860
Author: Adam Grare <agrare@redhat.com>
Date:   Fri Mar 16 15:18:45 2018 -0400

    Merge pull request #211 from bmclaughlin/fix-console-access-failures
    
    Fix WebMKS/VNC console access
    (cherry picked from commit d4656e696cd3e4d1e599302e08e4055610386ffc)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1558076

agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
@Fryguy
Merge pull request ManageIQ#211 from bdunne/bundler_1_16_0
8541111 
Bundler 1.16.0 is causing problems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@agrare agrare

Labels
blocker bug fine/backported gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bmclaughlin @agrare @miq-bot @skateman @simaishi @JPrause