Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift fog-vcloud-director version to 0.1.10 #224

Merged
merged 1 commit into from
Apr 3, 2018

Conversation

miha-plesko
Copy link
Contributor

With this commit we shift gem version because WebMKS console depends on some API calls that were only implemented in this version of the gem. Also, since the new gem shifts default version from 5.1 -> 5.5 and due to a bug that CloudProvider always uses default version no matter what version is stored in VMDB - we update the spec to match the new default.

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1560517

@miq-bot add_label enhancement,gaprindashvili/yes
@miq-bot assign @agrare

@miha-plesko miha-plesko changed the title Shift fox-vcloud-director version to 0.1.10 Shift fog-vcloud-director version to 0.1.10 Mar 30, 2018
@miha-plesko
Copy link
Contributor Author

Hey @agrare, wanted to let you know that this PR is compatible with the other one where we "actually apply API version" #219 and can be merged before or after it.

@miq-bot
Copy link
Member

miq-bot commented Apr 3, 2018

This pull request is not mergeable. Please rebase and repush.

With this commit we shift gem version because WebMKS console depends
on some API calls that were only implemented in this version of the
gem. Also, since the new gem shifts default version from 5.1 -> 5.5
and due to a bug that CloudProvider always uses default version no
matter what version is stored in VMDB - we update the spec to match
the new default.

Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
@miq-bot
Copy link
Member

miq-bot commented Apr 3, 2018

Checked commit miha-plesko@e0eec13 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 will merge when green

@agrare agrare merged commit e0eec13 into ManageIQ:master Apr 3, 2018
agrare added a commit that referenced this pull request Apr 3, 2018
Shift fog-vcloud-director version to 0.1.10
@agrare agrare added this to the Sprint 83 Ending Apr 9, 2018 milestone Apr 3, 2018
@agrare agrare removed the unmergeable label Apr 3, 2018
simaishi pushed a commit that referenced this pull request Apr 3, 2018
@simaishi
Copy link
Contributor

simaishi commented Apr 3, 2018

Gaprindashvili backport details:

$ git log -1
commit a7c376f5f5a04677ac95cb5963c92a3e03c696ff
Author: Adam Grare <agrare@redhat.com>
Date:   Tue Apr 3 09:08:15 2018 -0400

    Merge pull request #224 from miha-plesko/shift-fog-version
    
    Shift fog-vcloud-director version to 0.1.10
    (cherry picked from commit 3386b553fff6db82e4b8118fe831b750985d970b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1563364

agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
…zon_router_events

Force full refresh for router based events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants