Add support for reconfigure cdrom #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
force-pushed
the
bz_1533728_reconfigure_iso
branch
2 times, most recently
from
b0bb49d
to
4b810cd
Compare
agrare
force-pushed
the
bz_1533728_reconfigure_iso
branch
from
4b810cd
to
475438d
Compare
agrare
changed the title
agrare
force-pushed
the
bz_1533728_reconfigure_iso
branch
from
475438d
to
746484e
Compare
|
@blomquisg can you review? |
roliveri
reviewed
May 16, 2018
| @@ -345,6 +357,40 @@ def remove_network_adapter_config_spec(vim_obj, vmcs, options) | |||
| end | |||
| end | |||
|
|
|||
| def connect_cdrom_config_spec(vim_obj, vmcs, hardware, cdrom) | |||
| device = vim_obj.send(:getDeviceByLabel, cdrom[:device_name], hardware) | |||
There was a problem hiding this comment.
I know we did this before this change, but why do we send here. Are these methods private? If so, should they be public?
There was a problem hiding this comment.
Hm good question I don't know why we do that, let me try just calling it normally.
There was a problem hiding this comment.
Works fine, I'll change these over
agrare
force-pushed
the
bz_1533728_reconfigure_iso
branch
from
746484e
to
b689b8c
Compare
|
Checked commits agrare/manageiq-providers-vmware@fd8c9eb~...b689b8c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
roliveri
approved these changes
May 16, 2018
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
Automation for transformation plan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to connect and disconnect ISOs to VirtualCdrom drives
Depends on:
ManageIQ/vmware_web_service#37,ManageIQ/manageiq#17365https://bugzilla.redhat.com/show_bug.cgi?id=1533728