Don't cache host config.storageDevice #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
changed the title
agrare
force-pushed
the
dont_cache_host_storage_devices
branch
3 times, most recently
from
f79795d
to
3cfeaab
Compare
agrare
changed the title
agrare
force-pushed
the
dont_cache_host_storage_devices
branch
from
3cfeaab
to
f7e2ece
Compare
|
This pull request is not mergeable. Please rebase and repush. |
agrare
force-pushed
the
dont_cache_host_storage_devices
branch
from
f7e2ece
to
055c106
Compare
|
Checked commits agrare/manageiq-providers-vmware@e1b20d8~...055c106 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
[Changelog] Update for Sprint 83
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This particular property can blow out the memory consumption on larger deployments. Currently these are collected one at a time per host to prevent memory usage growing too large.
This change removes these properties from the propertyCollector update set and cache and instead retrieves them per host prior to parsing.