[GAPRINDASHVILI] Inventory VM's hostname as part of name #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miq-bot
changed the title
With this commit we inventory Vm's hostname rather as part of vm.name than as vm.hostname because vm.hostname attribute does not exist on yet on Gaprandishvilli. Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
miha-plesko
changed the title
|
NetworkManager was also failing because of hostname change, so I've repushed to fix it as well. Had to manually add some VCR responses because obtaining VM hostname requires additional API request that was not yet present in cassette. |
|
Checked commit miha-plesko@8118ee7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
agrare
approved these changes
Jun 1, 2018
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
…to_include_initializing Change check for start_retirement to not initialized vs retiring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we inventory Vm's hostname rather as part of vm.name than as vm.hostname because vm.hostname attribute does not exist on yet on Gaprandishvilli.
This is a commit to re-apply #195 after VM reconfigure backporting has been done.
@miq-bot assign @simaishi
/cc @agrare