Persister: InventoryCollection building through add_collection()

app/models/manageiq/providers/vmware/cloud_manager/refresh_parser.rb

@@ -141,6 +141,7 @@ def parse_vm(vm)
       :ems_ref                => uid,
       :name                   => name,
       :hostname               => hostname,
+      :location               => uid,
       :vendor                 => "vmware",
       :raw_power_state        => status,
       :snapshots              => [parse_snapshot(vm)].compact,
@@ -193,6 +194,7 @@ def parse_image(image, is_public)
       :uid_ems            => uid,
       :ems_ref            => uid,
       :name               => name,
+      :location           => uid,
       :vendor             => "vmware",
       :raw_power_state    => "never",
       :publicly_available => is_public

app/models/manageiq/providers/vmware/inventory/parser/cloud_manager.rb

@@ -33,6 +33,7 @@ def vms
         :uid_ems                => vm[:vm].id,
         :name                   => vm[:vm].name,
         :hostname               => vm[:hostname],
+        :location               => vm[:vm].id,
         :vendor                 => 'vmware',
         :raw_power_state        => vm[:vm].status,
         :orchestration_stack    => persister.orchestration_stacks.lazy_find(vm[:vm].vapp_id),
@@ -98,6 +99,7 @@ def images
       persister.miq_templates.find_or_build(image[:image].id).assign_attributes(
         :uid_ems            => image[:image].id,
         :name               => image[:image].name,
+        :location           => image[:image].id,
         :vendor             => 'vmware',
         :raw_power_state    => 'never',
         :publicly_available => image[:is_published]

app/models/manageiq/providers/vmware/inventory/persister.rb

@@ -7,7 +7,7 @@ def cloud
     ManageIQ::Providers::Vmware::InventoryCollectionDefault::CloudManager
   end
 
-  def targeted
+  def targeted?
     false
   end
 
@@ -20,7 +20,7 @@ def shared_options
 
     settings_options.merge(
       :strategy => strategy,
-      :targeted => targeted,
+      :targeted => targeted?,
     )
   end
 end

app/models/manageiq/providers/vmware/inventory/persister/cloud_manager.rb

@@ -1,18 +1,15 @@
 class ManageIQ::Providers::Vmware::Inventory::Persister::CloudManager < ManageIQ::Providers::Vmware::Inventory::Persister
+  include ::ManageIQ::Providers::Vmware::Inventory::Persister::Definitions::CloudCollections
+
   def initialize_inventory_collections
-    add_inventory_collections(
-      cloud,
-      %i(
-        availability_zones
-        orchestration_stacks
-        vms
-        snapshots
-        hardwares
-        disks
-        operating_systems
-        orchestration_templates
-        miq_templates
-      )
-    )
+    initialize_cloud_inventory_collections
+  end
+
+  def shared_options
+    {
+      :strategy => strategy,
+      :targeted => targeted?,
+      :parent   => manager.presence
+    }
   end
 end

app/models/manageiq/providers/vmware/inventory/persister/definitions/cloud_collections.rb

@@ -0,0 +1,46 @@
+module ManageIQ::Providers::Vmware::Inventory::Persister::Definitions::CloudCollections
+  extend ActiveSupport::Concern
+
+  def cloud
+    ::ManagerRefresh::InventoryCollection::Builder::CloudManager
+  end
+
+  def initialize_cloud_inventory_collections
+    %i(vms
+       availability_zones
+       disks
+       hardwares
+       operating_systems
+       snapshots).each do |name|
+
+      add_collection(cloud, name)
+    end
+
+    add_orchestration_templates
+
+    add_orchestration_stacks
+
+    add_miq_templates
+  end
+
+  # ------ IC provider specific definitions -------------------------
+
+  def add_miq_templates
+    add_collection(cloud, :miq_templates) do |builder|
+      builder.add_properties(:model_class => ::ManageIQ::Providers::Vmware::CloudManager::Template)
+    end
+  end
+
+  # TODO: mslemr - parent model_class used anywhere? If not, should be deleted from core
+  def add_orchestration_stacks
+    add_collection(cloud, :orchestration_stacks) do |builder|
+      builder.add_properties(:model_class => ::ManageIQ::Providers::Vmware::CloudManager::OrchestrationStack)
+    end
+  end
+
+  def add_orchestration_templates
+    add_collection(cloud, :orchestration_templates) do |builder|
+      builder.add_builder_params(:ems_id => manager.id)
+    end
+  end
+end

spec/models/manageiq/providers/vmware/cloud_manager/refresher_spec.rb

@@ -172,7 +172,7 @@ def assert_specific_template
       :vendor                => 'vmware',
       :power_state           => 'never',
       :publicly_available    => false,
-      :location              => 'unknown',
+      :location              => 'vm-ac90bd58-3bc4-47a5-bc8c-f1c8f5c468b6',
       :tools_status          => nil,
       :boot_time             => nil,
       :standby_action        => nil,
@@ -205,7 +205,7 @@ def assert_specific_vm_powered_on
       :uid_ems                => 'vm-84faa107-c0b9-4a21-adc5-b17e0c5355a2',
       :vendor                 => 'vmware',
       :power_state            => 'on',
-      :location               => 'unknown',
+      :location               => 'vm-84faa107-c0b9-4a21-adc5-b17e0c5355a2',
       :tools_status           => nil,
       :boot_time              => nil,
       :standby_action         => nil,
@@ -295,7 +295,7 @@ def assert_specific_vm_powered_off
       :uid_ems               => 'vm-aaf94123-cbf9-4de9-841c-41dd41ac310e',
       :vendor                => 'vmware',
       :power_state           => 'off',
-      :location              => 'unknown',
+      :location              => 'vm-aaf94123-cbf9-4de9-841c-41dd41ac310e',
       :tools_status          => nil,
       :boot_time             => nil,
       :standby_action        => nil,