Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug logging for object updates from the VC #293

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Add debug logging for object updates from the VC #293

merged 1 commit into from
Jul 10, 2018

Conversation

agrare
Copy link
Member

@agrare agrare commented Jul 9, 2018

This adds a debug logging method to print the object, the type of
update, and a short list of property names which changed.

Example:

Object: [Datastore:datastore-52] Kind: [modify] Props: [host["host-1836"].mountInfo, info.freeSpace, info.timestamp, summary.freeSpace]
Object: [VirtualMachine:vm-426] Kind: [modify] Props: [guest.net]
Object: [VirtualApp:resgroup-v3636] Kind: [modify] Props: [summary.config.cpuAllocation.expandableReservation, summary.config.cpuAllocation.limit, summary.config.cpuAllocation.reservation, summary.config.cpuAllocation.shares.level, summary.config.cpuAllocation.shares.shares, ...]

@agrare
Add debug logging for object updates from the VC
f4d0af2 
This adds a debug logging method to print the object, the type of
update, and a short list of property names which changed.

Example:
`Object: [Datastore:datastore-52] Kind: [modify] Props:
[host["host-1836"].mountInfo, info.freeSpace, info.timestamp,
summary.freeSpace]`
@miq-bot
Copy link
Member

miq-bot commented Jul 9, 2018

Checked commit agrare@f4d0af2 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

Ladas
Ladas approved these changes Jul 10, 2018
View reviewed changes
Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good

@Ladas Ladas merged commit 1895408 into ManageIQ:master Jul 10, 2018
@agrare agrare deleted the log_object_updates branch July 10, 2018 15:21
@Ladas Ladas added this to the Sprint 90 Ending Jul 16, 2018 milestone Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladas Ladas Ladas approved these changes

Assignees

@Ladas Ladas

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agrare @miq-bot @Ladas