Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting the last_refresh_date on error #301

Merged
merged 1 commit into from
Jul 20, 2018

Conversation

agrare
Copy link
Member

@agrare agrare commented Jul 20, 2018

Fix an issue where the last_refresh_date is being set incorrectly in the
exception handler when a refresh fails.

Fix an issue where the last_refresh_date is being set incorrectly in the
exception handler when a refresh fails.
@miq-bot
Copy link
Member

miq-bot commented Jul 20, 2018

Checked commit agrare@14c3a63 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice find

@Ladas Ladas merged commit 1753e37 into ManageIQ:master Jul 20, 2018
@Ladas Ladas added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 20, 2018
agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
@agrare agrare deleted the fix_last_refresh_date_on_error branch April 15, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants