Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the full URI for the broker connection #305

Merged
merged 4 commits into from
Jul 23, 2018

Conversation

agrare
Copy link
Member

@agrare agrare commented Jul 23, 2018

This changes the vmware provider to pass in the full URI that the broker
server is running on to allow for a UNIX file path to be used.

CVE Number: CVE-2018-10905
https://bugzilla.redhat.com/show_bug.cgi?id=1599389

Depends on: ManageIQ/vmware_web_service#42 (merged and 0.3.0 released)
Depends on: ManageIQ/manageiq-smartstate#76 (merged and 0.2.13 release)

This changes the vmware provider to pass in the full URI that the broker
server is running on to allow for a UNIX file path to be used.

CVE Number: CVE-2018-10905
https://bugzilla.redhat.com/show_bug.cgi?id=1599389
@Fryguy
Copy link
Member

Fryguy commented Jul 23, 2018

Depends on ManageIQ/vmware_web_service#42 and subsequent release.

@Fryguy Fryguy closed this Jul 23, 2018
@Fryguy Fryguy reopened this Jul 23, 2018
@Fryguy Fryguy closed this Jul 23, 2018
@Fryguy Fryguy reopened this Jul 23, 2018
@Fryguy
Copy link
Member

Fryguy commented Jul 23, 2018

Merging due to cross-conflict with ManageIQ/manageiq#17746

@Fryguy Fryguy merged commit 675cc09 into ManageIQ:master Jul 23, 2018
@agrare agrare deleted the use_unix_socket_for_drb_connection branch July 23, 2018 18:50
@agrare agrare added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 31, 2018
simaishi pushed a commit that referenced this pull request Jul 31, 2018
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

app/models/manageiq/providers/vmware/infra_manager/vm_or_template_shared/scanning.rb
manageiq-providers-vmware.gemspec

$ git log -1
commit 436a5ec6795f9a08f1b9ee3e2f3ec83c3eaf0e85
Author: Jason Frey <fryguy9@gmail.com>
Date:   Mon Jul 23 14:50:01 2018 -0400

    Merge pull request #305 from agrare/use_unix_socket_for_drb_connection
    
    Use the full URI for the broker connection
    (cherry picked from commit 675cc09cac238bfa52850a46d447afa2a9143aa2)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1608552

The rest of the files in the PR was backported to manageiq repo:

commit 11ad59c4344774245ba885ce4c40aeda85911184
Author: Jason Frey <fryguy9@gmail.com>
Date:   Mon Jul 23 14:50:01 2018 -0400

    Merge pull request #305 from agrare/use_unix_socket_for_drb_connection
    
    Use the full URI for the broker connection
    (cherry picked from commit 675cc09cac238bfa52850a46d447afa2a9143aa2)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1608552

simaishi pushed a commit that referenced this pull request Aug 14, 2018
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 67313b327a7a98d9b42254b0a9fdc483c978bba5
Author: Jason Frey <fryguy9@gmail.com>
Date:   Mon Jul 23 14:50:01 2018 -0400

    Merge pull request #305 from agrare/use_unix_socket_for_drb_connection
    
    Use the full URI for the broker connection
    (cherry picked from commit 675cc09cac238bfa52850a46d447afa2a9143aa2)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1603578

To manageiq repo

$ git log -1
commit 35443398f71633ae964c2c56743c0aa8c24a27f2
Author: Jason Frey <fryguy9@gmail.com>
Date:   Mon Jul 23 14:50:01 2018 -0400

    Merge pull request #305 from agrare/use_unix_socket_for_drb_connection
    
    Use the full URI for the broker connection
    (cherry picked from commit 675cc09cac238bfa52850a46d447afa2a9143aa2)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1603578

agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
…miqprovision

Updated Email instances for Infra VM provisioning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants