Add thumbprint_sha1 method to host_esx #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
reviewed
Oct 4, 2018
| @@ -177,4 +177,8 @@ def refresh_advanced_settings | |||
| def self.display_name(number = 1) | |||
| n_('Host (Vmware)', 'Hosts (Vmware)', number) | |||
| end | |||
|
|
|||
| def thumbprint_sha1 | |||
| ESXThumbPrint.new(ipaddress, authentication_userid, authentication_password).to_sha1 | |||
There was a problem hiding this comment.
Probably need to require VMwareWebService/esx_thumb_print right above this`
ghost
mentioned this pull request
|
@miq-bot add-label enhancement, transformation |
agrare
approved these changes
Oct 4, 2018
agrare
added a commit
that referenced
this pull request
Oct 4, 2018
Add thumbprint_sha1 method to host_esx
ghost
deleted the
simaishi
pushed a commit
that referenced
this pull request
Oct 4, 2018
Add thumbprint_sha1 method to host_esx (cherry picked from commit a649de7)
|
Hammer backport details: |
|
@fdupont-redhat Cannot apply the following label because they are not recognized: transformation |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For VM migration, we need the thumbprint of the ESX host where the VM resides (
vm.host). This PR adds a method namedthumbprint_sha1that returns the needed fingerprint.Required by: ManageIQ/manageiq#18033
Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1634029