-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VMware content library refresh #444
Conversation
@@ -40,6 +40,9 @@ def initialize_inventory_collections | |||
add_collection(infra, :vm_parent_blue_folders) | |||
add_collection(infra, :vm_resource_pools) | |||
add_collection(infra, :root_folder_relationship) | |||
add_collection(infra, :orchestration_templates) do |builder| | |||
builder.add_default_values(:ems_id => manager.id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a helper method for this, builder.add_common_default_values
@@ -40,6 +40,9 @@ def initialize_inventory_collections | |||
add_collection(infra, :vm_parent_blue_folders) | |||
add_collection(infra, :vm_resource_pools) | |||
add_collection(infra, :root_folder_relationship) | |||
add_collection(infra, :orchestration_templates) do |builder| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this to work we need to add the has_many :orchestration_templates
association to the vmware infra_manager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I have it in manageiq repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 that works too, we'll just need to add that assoc to the base InfraManager class then too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about having it here. But the CloudManager has the corresponding one in manageiq.
@miq-bot add_labels enhancement |
Checked commits https://github.com/jameswnl/manageiq-providers-vmware/compare/dccff017e2f23d2232e15dd969a391d8775a2160~...835b7478e3c40202cf6228be4687b17f093e60d6 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
To refresh and inventory VMware Content Library items.
(At this stage, no need to inventory the Libraries.)
Depending on ManageIQ/manageiq#19269