Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware content library refresh #444

Merged
merged 4 commits into from
Sep 6, 2019
Merged

VMware content library refresh #444

merged 4 commits into from
Sep 6, 2019

Conversation

jameswnl
Copy link
Contributor

@jameswnl jameswnl commented Sep 5, 2019

To refresh and inventory VMware Content Library items.
(At this stage, no need to inventory the Libraries.)

Depending on ManageIQ/manageiq#19269

@miq-bot miq-bot added the wip label Sep 5, 2019
@agrare agrare self-assigned this Sep 5, 2019
@jameswnl jameswnl closed this Sep 5, 2019
@jameswnl jameswnl reopened this Sep 5, 2019
@@ -40,6 +40,9 @@ def initialize_inventory_collections
add_collection(infra, :vm_parent_blue_folders)
add_collection(infra, :vm_resource_pools)
add_collection(infra, :root_folder_relationship)
add_collection(infra, :orchestration_templates) do |builder|
builder.add_default_values(:ems_id => manager.id)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a helper method for this, builder.add_common_default_values

@@ -40,6 +40,9 @@ def initialize_inventory_collections
add_collection(infra, :vm_parent_blue_folders)
add_collection(infra, :vm_resource_pools)
add_collection(infra, :root_folder_relationship)
add_collection(infra, :orchestration_templates) do |builder|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this to work we need to add the has_many :orchestration_templates association to the vmware infra_manager

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I have it in manageiq repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 that works too, we'll just need to add that assoc to the base InfraManager class then too

Copy link
Contributor Author

@jameswnl jameswnl Sep 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about having it here. But the CloudManager has the corresponding one in manageiq.

@jameswnl jameswnl changed the title [WIP] VMware content library refresh VMware content library refresh Sep 6, 2019
@jameswnl
Copy link
Contributor Author

jameswnl commented Sep 6, 2019

@miq-bot add_labels enhancement

@agrare agrare removed the wip label Sep 6, 2019
@miq-bot
Copy link
Member

miq-bot commented Sep 6, 2019

Checked commits https://github.com/jameswnl/manageiq-providers-vmware/compare/dccff017e2f23d2232e15dd969a391d8775a2160~...835b7478e3c40202cf6228be4687b17f093e60d6 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
5 files checked, 0 offenses detected
Everything looks fine. 👍

agrare added a commit that referenced this pull request Sep 6, 2019
VMware content library refresh
@agrare agrare merged commit 835b747 into ManageIQ:master Sep 6, 2019
@agrare agrare added this to the Sprint 120 Ending Sep 16, 2019 milestone Sep 6, 2019
@jameswnl jameswnl deleted the contents branch September 9, 2019 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants