Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect OpaqueNetworks and OpaqueSwitches #449

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Collect OpaqueNetworks and OpaqueSwitches #449

merged 1 commit into from
Sep 17, 2019

Conversation

agrare
Copy link
Member

@agrare agrare commented Sep 11, 2019 •
edited
Loading

Add support for collecting OpaqueNetworks and OpaqueSwitches from VMware

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1751351

@agrare agrare force-pushed the collect_opaque_networks branch 2 times, most recently from 5ab2846 to bff3a1f Compare September 11, 2019 19:58
@agrare
Copy link
Member Author

agrare commented Sep 12, 2019

@gtanzillo can you take a look? A customer tested this end-to-end with provisioning

@agrare
Collect OpaqueNetworks and OpaqueSwitches
21d7d0a 
Add support for collecting OpaqueNetworks and OpaqueSwitches from VMware

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1751351
@miq-bot
Copy link
Member

miq-bot commented Sep 13, 2019

Checked commit agrare@21d7d0a with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 👍

@agrare
Copy link
Member Author

agrare commented Sep 16, 2019

@Ladas can you take a look?

Ladas
Ladas approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good

@Ladas Ladas added this to the Sprint 120 Ending Sep 16, 2019 milestone Sep 17, 2019
@Ladas Ladas merged commit 0b96575 into ManageIQ:master Sep 17, 2019
@Ladas
Copy link
Contributor

Ladas commented Sep 17, 2019

@agrare will you send PR also for the graph refresh?

@agrare agrare deleted the collect_opaque_networks branch September 17, 2019 12:37
@agrare
Copy link
Member Author

agrare commented Sep 17, 2019

Yes, wanted to confirm this actually works given I don't have an env to test it on first :)

@agrare agrare mentioned this pull request Sep 17, 2019
Merged
@simaishi
Copy link
Contributor

@agrare can this be ivanchuk/yes?

@agrare
Copy link
Member Author

agrare commented Feb 21, 2020

@simaishi sure, make sure to backport together with #453

simaishi pushed a commit that referenced this pull request Feb 21, 2020
@Ladas @simaishi
Merge pull request #449 from agrare/collect_opaque_networks
9430feb 
Collect OpaqueNetworks and OpaqueSwitches

(cherry picked from commit 0b96575)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1805799
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 9430feb53fc46314926be42d8aeb511888c28ae4
Author: Ladislav Smola <lsmola@redhat.com>
Date:   Tue Sep 17 10:46:59 2019 +0200

    Merge pull request #449 from agrare/collect_opaque_networks

    Collect OpaqueNetworks and OpaqueSwitches

    (cherry picked from commit 0b9657577b15f3eebfc4f328249b7efd2b6ddb56)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1805799

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladas Ladas Ladas approved these changes

Assignees

@gtanzillo gtanzillo

Labels
enhancement ivanchuk/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@agrare @miq-bot @Ladas @simaishi @gtanzillo