Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various small fixes to VimConnectMixin without the broker #516

Merged
merged 3 commits into from
Jan 23, 2020

Conversation

agrare
Copy link
Member

@agrare agrare commented Jan 23, 2020

  1. Make sure to disconnect after raw_connect to verify credentials
  2. Clear the connection and reconnect if the conn isn't alive
  3. Don't rescue broker exception if we're not using the broker

#484

@agrare agrare requested a review from Fryguy as a code owner January 23, 2020 15:31
@gtanzillo gtanzillo self-assigned this Jan 23, 2020
@gtanzillo gtanzillo modified the milestone: Sprint 129 Ending Feb 3, 2020 Jan 23, 2020
@miq-bot
Copy link
Member

miq-bot commented Jan 23, 2020

Checked commits agrare/manageiq-providers-vmware@e814568~...a53ba3b with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

app/models/manageiq/providers/vmware/infra_manager/vim_connect_mixin.rb

@gtanzillo gtanzillo added this to the Sprint 129 Ending Feb 3, 2020 milestone Jan 23, 2020
@gtanzillo gtanzillo merged commit 226d332 into ManageIQ:master Jan 23, 2020
@agrare agrare deleted the vim_connect_mixin_fixes branch January 23, 2020 18:03
@mfeifer mfeifer added the bug label Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants