Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode slashes in more VMware inventory type names #53

Merged

Conversation

agrare
Copy link
Member

@agrare agrare commented May 3, 2017

Decode slashes in folder names, and all the other types while we're at it!

I found that there are a number of additional inventory types where we will get %2f back from the VIM API so just fixed them here:

  1. Folders
  2. Datacenters
  3. Datastores
  4. Clusters

https://bugzilla.redhat.com/show_bug.cgi?id=1393655

@agrare agrare added the bug label May 3, 2017
@miq-bot
Copy link
Member

miq-bot commented May 3, 2017

Checked commits agrare/manageiq-providers-vmware@4cfc246~...513b8f5 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 1 offense detected

spec/models/manageiq/providers/vmware/infra_manager/refresher_spec.rb

Copy link
Member

@blomquisg blomquisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blomquisg
Copy link
Member

Sorry for the label confusion ... I misread the bug.

At the moment the BZ is not requesting a Fine fix

@blomquisg blomquisg merged commit 20ead41 into ManageIQ:master May 4, 2017
@blomquisg blomquisg added this to the Sprint 60 Ending May 8, 2017 milestone May 4, 2017
@agrare agrare deleted the bz_1393655_decode_slash_in_folders branch May 4, 2017 18:30
agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
Automate method to list ansible credentials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants