Adjusted DDF schema for infra provider creation + validation #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
4 tasks
skateman
force-pushed
the
adjust-ddf-schema
branch
2 times, most recently
from
06a3b5c
to
4295e2e
Compare
skateman
force-pushed
the
adjust-ddf-schema
branch
from
4295e2e
to
ca2d5f8
Compare
|
Checked commits skateman/manageiq-providers-vmware@c363eb8~...ca2d5f8 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
agrare
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusting the DDF forms to provide the same experience as the old ones.
Before:
After:
There's a slight change on the VMRC Console tab, I added a protocol-selector component to enable/disable the console support. This allows the username/password fields to be required and obsoletes the additional info field.
@miq-bot add_label enhancement
@miq-bot assign @agrare
Parent issue: ManageIQ/manageiq#18818