Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm restart guest check fixed #64

Merged
merged 1 commit into from
Jun 12, 2017
Merged

vm restart guest check fixed #64

merged 1 commit into from
Jun 12, 2017

Conversation

jameswnl
Copy link
Contributor

@jameswnl jameswnl commented Jun 12, 2017 •
edited
Loading

https://bugzilla.redhat.com/show_bug.cgi?id=1455595

Before

Guest restart is displayed as doable even when tools is not installed

After

Guest restart is not allowed when tools is not installed

@jameswnl
Copy link
Contributor Author

@miq-bot add_labels bug, fine/yes

agrare
agrare approved these changes Jun 12, 2017
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@agrare
Copy link
Member

agrare commented Jun 12, 2017

Just noticed the commit author,

commit 8c30a5e
Author: James Wong jwong@jwong-OSX.local
Date: Sun Jun 11 21:57:35 2017 -0400

@jameswnl can you set your git user.email and re-push?

@miq-bot
Copy link
Member

miq-bot commented Jun 12, 2017

Checked commit https://github.com/jameswnl/manageiq-providers-vmware/commit/81ecc9c3f38f51124b32e9da0c168fa1c87cff6d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@agrare agrare merged commit a114185 into ManageIQ:master Jun 12, 2017
simaishi pushed a commit that referenced this pull request Jun 14, 2017
@agrare @simaishi
Merge pull request #64 from jameswnl/support-reboot
a1dd5ca 
vm restart guest check fixed
(cherry picked from commit a114185)

https://bugzilla.redhat.com/show_bug.cgi?id=1461475
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit a1dd5cad9e9467565686a225db8c5bbdd0fa10cc
Author: Adam Grare <agrare@redhat.com>
Date:   Mon Jun 12 12:28:04 2017 -0400

    Merge pull request #64 from jameswnl/support-reboot
    
    vm restart guest check fixed
    (cherry picked from commit a114185b018975384146699436141f1c2e5b7139)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1461475

@agrare agrare added this to the Sprint 63 Ending Jun 19, 2017 milestone Jun 14, 2017
@agrare agrare self-assigned this Jun 5, 2018
agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
@gmcculloug
Merge pull request ManageIQ#64 from mfeifer/changelog55
d07f03b 
Changelog 55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

Assignees

@agrare agrare

Labels
bug fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jameswnl @agrare @miq-bot @simaishi