Rbvmomi inventory collector

[agrare]

Add an inventory collection strategy that uses WaitForUpdates instead of events and RetrieveProperties through the broker. This uses the RbVmomi gem from VMware.

[agrare]

This keeps the property names as they are send from VMware, so e.g. props["summary.config.name"] instead of the broker which currently splits that up into props["summary"]["config"]["name"].

I'd like to keep it as close to what VMware sends if possible since what the broker does will be a little tricky without everything cached. This just means the parsers will have to be able to handle updates to arrays e.g.: config.hardware.device[\"1000\"].device = [2000, 2001]

[Fryguy]

Can we delay load this?

[agrare]

Yes we can, done

[Fryguy]

capital L. ewww 😦

[miq-bot]

Checked commits agrare/manageiq-providers-vmware@c0787ff~...4b07676 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
6 files checked, 4 offenses detected

app/models/manageiq/providers/vmware/infra_manager/inventory/collector/inventory_cache.rb

• ❗ - Line 8, Col 47 - Style/EmptyLiteral - Use hash literal {} instead of Hash.new.

app/models/manageiq/providers/vmware/infra_manager/inventory/collector/property_collector.rb

• ❗ - Line 50, Col 37 - Style/WordArray - Use %w or %W for an array of words.
• ❗ - Line 87, Col 37 - Style/WordArray - Use %w or %W for an array of words.
• ❗ - Line 92, Col 37 - Style/WordArray - Use %w or %W for an array of words.