Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark and logging around storage profiles #81

Merged
merged 1 commit into from
Jul 27, 2017

Conversation

agrare
Copy link
Member

@agrare agrare commented Jul 20, 2017

Collection of storage profiles were not reflected it their own benchmark
timings and were not logged making it difficult to diagnose when their
collection is slow

https://bugzilla.redhat.com/show_bug.cgi?id=1473379

Collection of storage profiles were not reflected it their own benchmark
timings and were not logged making it difficult to diagnose when their
collection is slow

https://bugzilla.redhat.com/show_bug.cgi?id=1473379
@miq-bot
Copy link
Member

miq-bot commented Jul 20, 2017

Checked commit agrare@5758db5 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@blomquisg blomquisg merged commit a3d6faa into ManageIQ:master Jul 27, 2017
@blomquisg blomquisg added this to the Sprint 66 Ending Aug 7, 2017 milestone Jul 27, 2017
@agrare agrare deleted the storage_profile_logging branch July 27, 2017 16:46
@JPrause
Copy link
Member

JPrause commented Aug 7, 2018

@miq-bot add_label blocker

@miq-bot miq-bot added the blocker label Aug 7, 2018
@JPrause
Copy link
Member

JPrause commented Aug 7, 2018

@agrare if this can be backported, can you add the fine/yes label.

simaishi pushed a commit that referenced this pull request Aug 14, 2018
Add benchmark and logging around storage profiles
(cherry picked from commit a3d6faa)

https://bugzilla.redhat.com/show_bug.cgi?id=1593914
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 9b52490526b6b8070b227fbb13c0f271b1b9d330
Author: Greg Blomquist <blomquisg@gmail.com>
Date:   Thu Jul 27 12:45:46 2017 -0400

    Merge pull request #81 from agrare/storage_profile_logging
    
    Add benchmark and logging around storage profiles
    (cherry picked from commit a3d6faab74c911bd225bc1b4b078dd8f890fb00e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1593914

agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
…maint_check

Modified vmware_best_fit_least_utilized to not select Hosts in maintenance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants