Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup GitHub Actions #238

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Cleanup GitHub Actions #238

merged 1 commit into from
Dec 20, 2021

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Dec 20, 2021

  • Add "needs"
  • Use event_name to check for PRs
  • Use env section for env vars

@bdunne Please review

@Fryguy
Cleanup GitHub Actions
4e0bb02 
- Add "needs"
- Use event_name to check for PRs
- Use env section for env vars
@miq-bot
Copy link
Member

miq-bot commented Dec 20, 2021

Checked commit Fryguy@4e0bb02 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@Fryguy Fryguy changed the title Cleanup GitHub Actions [WIP] Cleanup GitHub Actions Dec 20, 2021
@miq-bot miq-bot added the wip label Dec 20, 2021
@bdunne bdunne merged commit 1a7ca3b into ManageIQ:master Dec 20, 2021
@chessbyte
Copy link
Member

should this be unWIPed? :-)

@Fryguy
Copy link
Member Author

Fryguy commented Dec 20, 2021

Yeah I was trying to use a context instead of an env var for the TRAVIS_BRANCH, but I can do a follow up

@Fryguy Fryguy changed the title [WIP] Cleanup GitHub Actions Cleanup GitHub Actions Dec 20, 2021
@Fryguy Fryguy deleted the github_actions_cleanup branch December 20, 2021 17:31
@Fryguy Fryguy mentioned this pull request Dec 21, 2021
Closed
@Fryguy
Copy link
Member Author

Fryguy commented Jan 25, 2022

Backported to morphy in commit 72d9160.

commit 72d91602f9ff64bf7b1e79706cb20709232ae676
Author: Brandon Dunne <brandondunne@hotmail.com>
Date:   Mon Dec 20 10:00:07 2021 -0500

    Merge pull request #238 from Fryguy/github_actions_cleanup
    
    [WIP] Cleanup GitHub Actions
    
    (cherry picked from commit 1a7ca3b4390fc07b25a0407b5923f64d3b40bb5b)

Fryguy pushed a commit that referenced this pull request Jan 25, 2022
@bdunne @Fryguy
Merge pull request #238 from Fryguy/github_actions_cleanup
72d9160 
[WIP] Cleanup GitHub Actions

(cherry picked from commit 1a7ca3b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bdunne bdunne

Labels
cleanup morphy/backported test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fryguy @miq-bot @chessbyte @bdunne