address feedback

ManageIQ · Jan 26, 2021 · 1d7517b · 1d7517b
1 parent 7a1dfc4
commit 1d7517b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/db/migrate/20200607025146_add_ancestry_to_vm.rb b/db/migrate/20200607025146_add_ancestry_to_vm.rb
@@ -38,7 +38,7 @@ def transfer_relationships_to_ancestry(dest_model, resource_type, relationship)
 
   # src is vm, dest is relationship
   def create_relationships_from_ancestry(src_model, dest_model, resource_type, relationship)
-    children = src_model.select("ancestry::bigint").where("ancestry not like '%/%'")
+    children = src_model.select("ancestry::bigint").where("ancestry NOT LIKE '%/%'")
     rels = src_model.where.not(:ancestry => nil).or(src_model.where(:id => children)).map do |obj|
       dest_model.create!(:relationship  => relationship,
                          :resource_type => resource_type,

diff --git a/spec/migrations/20200607025146_add_ancestry_to_vm_spec.rb b/spec/migrations/20200607025146_add_ancestry_to_vm_spec.rb
@@ -167,8 +167,9 @@ def traverse(tree, parent, &block)
         yield(parent, key)
         traverse(children, parent + [key], &block)
       end
+    when nil
     else
-      puts "curious type: #{tree.class.name}"
+      raise StandardError, "curious type: #{tree.class.name}"
     end
   end