Splitting struct/data migrations

https://bugzilla.redhat.com/show_bug.cgi?id=1455145

db/migrate/20180618083035_add_visible_to_zone.rb

@@ -1,11 +1,5 @@
 class AddVisibleToZone < ActiveRecord::Migration[5.0]
  def change
  add_column :zones, :visible, :boolean, :default => true
- reversible do |dir|
- dir.up do
- ::Zone.reset_column_information
- ::Zone.seed
- end
- end
  end
 end

db/migrate/20180626125654_make_maintenance_zone_record.rb

@@ -0,0 +1,16 @@
+class MakeMaintenanceZoneRecord < ActiveRecord::Migration[5.0]
+ class Zone < ActiveRecord::Base
+ end
+
+ def up
+ say_with_time("Creating Maintenance Zone") do
+ Zone.create_with(:description => "Maintenance Zone", :visible => false).find_or_create_by!(:name => 'maintenance')
+ end
+ end
+
+ def down
+ say_with_time("Deleting Maintenance Zone") do
+ Zone.where(:name => 'maintenance').where(:visible => false).destroy_all
+ end
+ end
+end

spec/migrations/20180626125654_make_maintenance_zone_record_spec.rb

@@ -0,0 +1,25 @@
+require_migration
+
+describe MakeMaintenanceZoneRecord do
+ let(:zone_stub) { migration_stub(:Zone) }
+
+ migration_context :up do
+ it "Adds MaintenanceZone" do
+ migrate
+
+ expect(zone_stub.where(:name => 'maintenance').where(:visible => false).count).to eq(1)
+ end
+ end
+
+ migration_context :down do
+ it "removes MaintenanceZone" do
+ zone_stub.create!(:name => 'maintenance',
+ :description => 'Maintenance Zone',
+ :visible => false)
+
+ migrate
+
+ expect(zone_stub.where(:name => 'maintenance').where(:visible => false).count).to eq(0)
+ end
+ end
+end