Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the db:check_schema task to the public tasks.rake file #124

Merged
merged 1 commit into from
Nov 13, 2017

Conversation

carbonin
Copy link
Member

@carbonin carbonin commented Nov 8, 2017

This will allow it to be used by users when attempting to correct column ordering issues after migrating.

https://bugzilla.redhat.com/show_bug.cgi?id=1508537

This will allow it to be used by users when attempting to correct
column ordering issues after migrating

https://bugzilla.redhat.com/show_bug.cgi?id=1508537
@miq-bot
Copy link
Member

miq-bot commented Nov 8, 2017

Some comments on commit carbonin@863e6cd

lib/tasks/schema_tasks.rake

  • ⚠️ - 6 - Detected puts. Remove all debugging statements.

@miq-bot
Copy link
Member

miq-bot commented Nov 8, 2017

Checked commit carbonin@863e6cd with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@carbonin
Copy link
Member Author

carbonin commented Nov 9, 2017

@miq-bot add_label bug
@miq-bot assign @Fryguy

@carbonin
Copy link
Member Author

@miq-bot add_label gaprindashvili/yes, blocker

@Fryguy Fryguy merged commit ad336bd into ManageIQ:master Nov 13, 2017
@Fryguy Fryguy added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 13, 2017
@Fryguy
Copy link
Member

Fryguy commented Nov 13, 2017

cc @simaishi

simaishi pushed a commit that referenced this pull request Nov 15, 2017
Move the db:check_schema task to the public tasks.rake file
(cherry picked from commit ad336bd)

https://bugzilla.redhat.com/show_bug.cgi?id=1513143
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 828d50c74f4b772d7ed57e78d9a94f14244c866a
Author: Jason Frey <fryguy9@gmail.com>
Date:   Mon Nov 13 15:52:26 2017 -0500

    Merge pull request #124 from carbonin/make_schema_check_and_write_public
    
    Move the db:check_schema task to the public tasks.rake file
    (cherry picked from commit ad336bd67a970b12d29a74295881fcf7a4b5895f)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1513143

@carbonin
Copy link
Member Author

@simaishi I assume you didn't mean to add gaprindashvili/no here, right?

@simaishi
Copy link
Contributor

Oops. I'm glad someone is paying attention 😄 Thanks for catching.

@carbonin carbonin deleted the make_schema_check_and_write_public branch November 15, 2017 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants