Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Openstack refresh settings under the root where they belong #146

Merged
merged 1 commit into from
Jan 18, 2018
Merged

Move Openstack refresh settings under the root where they belong #146

merged 1 commit into from
Jan 18, 2018

Conversation

mansam
Copy link
Contributor

@mansam mansam commented Dec 21, 2017 •
edited by Fryguy
Loading

Openstack refresh settings are mistakenly nested under ems.ems_refresh.openstack*, but ems_refresh is supposed to be a top level key. Should be merged along with ManageIQ/manageiq-providers-openstack#175

https://bugzilla.redhat.com/show_bug.cgi?id=1519214

@miq-bot
Copy link
Member

miq-bot commented Dec 21, 2017

Checked commit mansam@ccfad40 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@mansam mansam mentioned this pull request Jan 11, 2018
Closed
@mansam
Copy link
Contributor Author

mansam commented Jan 15, 2018

@miq-bot add_label gaprindashvili/yes

@mansam
Copy link
Contributor Author

mansam commented Jan 15, 2018

@Fryguy can this be merged? Its parent PR has been merged. ManageIQ/manageiq-providers-openstack#175

@Fryguy Fryguy added the data label Jan 18, 2018
@Fryguy Fryguy merged commit 78f3316 into ManageIQ:master Jan 18, 2018
@Fryguy Fryguy added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 18, 2018
@Fryguy Fryguy self-assigned this Jan 18, 2018
@Fryguy Fryguy added the blocker label Jan 18, 2018
@Fryguy
Copy link
Member

Fryguy commented Jan 18, 2018

https://bugzilla.redhat.com/show_bug.cgi?id=1519214

simaishi pushed a commit that referenced this pull request Jan 18, 2018
@Fryguy @simaishi
Merge pull request #146 from mansam/ems-refresh-openstack
9b6d0fa 
Move Openstack refresh settings under the root where they belong
(cherry picked from commit 78f3316)

https://bugzilla.redhat.com/show_bug.cgi?id=1533225
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

 $ git log -1
commit 9b6d0fa7ba9f0e41c6cd20b7373ef1bc731c3a3c
Author: Jason Frey <fryguy9@gmail.com>
Date:   Thu Jan 18 14:01:03 2018 -0500

    Merge pull request #146 from mansam/ems-refresh-openstack
    
    Move Openstack refresh settings under the root where they belong
    (cherry picked from commit 78f33169a632926d9b2dcb30bde37bf18f5eb344)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1533225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Fryguy Fryguy

Labels
blocker data gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mansam @miq-bot @Fryguy @simaishi