Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tables for v2v migration #149

Merged
merged 1 commit into from
Jan 18, 2018
Merged

Add tables for v2v migration #149

merged 1 commit into from
Jan 18, 2018

Conversation

bzwei
Copy link
Contributor

@bzwei bzwei commented Jan 5, 2018

@bzwei bzwei force-pushed the v2v_schema branch 2 times, most recently from 754ecd4 to 38b5548 Compare January 9, 2018 20:52
@bzwei
Copy link
Contributor Author

bzwei commented Jan 10, 2018

@miq-bot assign @Fryguy
cc @gmcculloug

@Fryguy
Copy link
Member

Fryguy commented Jan 18, 2018

As discussed

  • drop the legit column
  • change comments from text to string
  • index on v2v_mapping_items should be on v2v_mapping_id instead
  • drop the last migration and put it into service_resource instead
  • add options as json column to both tables
  • change the names to transformation_mappings and transformation_mapping_items (don't forget the file names)

@miq-bot
Copy link
Member

miq-bot commented Jan 18, 2018

Checked commit bzwei@d9de151 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 2 offenses detected

db/migrate/20171219151634_create_transformation_mapping_items.rb

db/migrate/20171219161635_create_transformation_mappings.rb

@Fryguy Fryguy merged commit 69e98a6 into ManageIQ:master Jan 18, 2018
@Fryguy Fryguy added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 18, 2018
simaishi pushed a commit that referenced this pull request Jan 18, 2018
Add tables for v2v migration
(cherry picked from commit 69e98a6)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit c3d2c7c15e7cb634559c8ddbd8817f29c9cb7c5a
Author: Jason Frey <fryguy9@gmail.com>
Date:   Thu Jan 18 16:27:42 2018 -0500

    Merge pull request #149 from bzwei/v2v_schema
    
    Add tables for v2v migration
    (cherry picked from commit 69e98a69cba8eee9fab87928cc54005bdf87f96a)

@gmcculloug
Copy link
Member

@miq-bot add_label transformation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants