create a physical rack table #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 19, 2018
agrare
reviewed
Feb 15, 2018
| @@ -0,0 +1,5 @@ | |||
| class AddPhysicalRackToPhysicalServers < ActiveRecord::Migration[5.0] | |||
| def change | |||
| add_column :physical_servers, :physical_rack_id, :bigint | |||
There was a problem hiding this comment.
Don't think you need/want to do this in its own migration, adding a column to the new table in the above migration is fine /cc @Fryguy opinions?
felipedf
force-pushed
the
create_rack
branch
from
8723802 to
35adc18
Compare
|
@agrare resolved |
felipedf
force-pushed
the
create_rack
branch
from
35adc18 to
2be9ef9
Compare
|
Checked commit felipedf@2be9ef9 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@felipedf I just realized this didn't include an ems_ref column, which is generally required if the table is to be filled in during inventory refresh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This create a new table physical_racks and provides a :physical_rack_id column to physical_servers table.