Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete the dangling blob when there is a blob without a picture #158

Merged
merged 1 commit into from
Jan 18, 2018
Merged

Delete the dangling blob when there is a blob without a picture #158

merged 1 commit into from
Jan 18, 2018

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Jan 18, 2018

@miq-bot
Copy link
Member

miq-bot commented Jan 18, 2018

Checked commit bdunne@0200462 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 2 offenses detected

spec/migrations/20180111162442_move_pictures_blobs_to_pictures_spec.rb

@Fryguy Fryguy merged commit c976cfa into ManageIQ:master Jan 18, 2018
@Fryguy Fryguy self-assigned this Jan 18, 2018
@Fryguy Fryguy added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 18, 2018
@bdunne bdunne deleted the move_pictures branch January 18, 2018 17:22
@bdunne bdunne mentioned this pull request Jan 18, 2018
Merged
simaishi pushed a commit that referenced this pull request Jan 18, 2018
@Fryguy @simaishi
Merge pull request #158 from bdunne/move_pictures
7071362 
Delete the dangling blob when there is a blob without a picture
(cherry picked from commit c976cfa)

https://bugzilla.redhat.com/show_bug.cgi?id=1536046
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 70713628790d5cb649e5b5a5c4587a64f4c797ab
Author: Jason Frey <fryguy9@gmail.com>
Date:   Thu Jan 18 12:21:35 2018 -0500

    Merge pull request #158 from bdunne/move_pictures
    
    Delete the dangling blob when there is a blob without a picture
    (cherry picked from commit c976cfa3491706daa0ae23d92f1074af636dfce8)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1536046

@Fryguy Fryguy added the schema label Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Fryguy Fryguy

Labels
blocker bug gaprindashvili/backported schema
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdunne @miq-bot @simaishi @Fryguy