Updating switches data #160
Conversation
saulotoledo
force-pushed
the
updating_switches_data
branch
3 times, most recently
from
ab57ac5
to
78dd9df
Compare
saulotoledo
force-pushed
the
updating_switches_data
branch
2 times, most recently
from
4783b27
to
afe45b4
Compare
|
@Fryguy, could you take a look at this PR? |
saulotoledo
force-pushed
the
updating_switches_data
branch
from
afe45b4
to
65bd625
Compare
|
@saulotoledo I think while we're at it we should add a |
|
Hi @agrare. I was playing for some time with that before doing the change. I added the :type but the ActiveRecord is not proper saving it. Sounds like the refresher is using a generic class to save the hash, so that will not work. Doing some research I see that actually the type for physical servers is filled manually by the parser in order to do a workaround here. I can do the same, but I cannot assure that it will be filled for other providers. How do you think I should proceed? |
|
@saulotoledo try adding |
saulotoledo
force-pushed
the
updating_switches_data
branch
from
65bd625
to
93d4959
Compare
saulotoledo
force-pushed
the
updating_switches_data
branch
2 times, most recently
from
4f0eebf
to
0c1fc0b
Compare
|
@agrare, it is done. I also added a new migration to the guest_devices table. It is an information that we need to be able to discover the connected devices. Let me know what you think about. |
|
I will add a property to store the switch's MAC addresses. I will remove the WIP prefix after the update. |
saulotoledo
force-pushed
the
updating_switches_data
branch
from
0c1fc0b
to
9e9091c
Compare
|
@agrare, @rodneyhbrown7, the mac_addresses column was added. The parser has also been updated. |
saulotoledo
force-pushed
the
updating_switches_data
branch
from
9e9091c
to
4bc1eef
Compare
|
Checked commit saulotoledo@4bc1eef with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
No PhysicalStorage mention power_state. It is not defined in the schema nor is it a virtual attribute. Lenovo praser does parse this out but there is nowhere to put the value. They did add the column to PhysicalServer and PhysicalSwitch, so I think this was an oversight. pr for switch: ManageIQ/manageiq-schema#160 pr for server: ManageIQ/manageiq-schema@8e95341 Lets add this field back in once it is in the database schema
No PhysicalStorage mention power_state. It is not defined in the schema nor is it a virtual attribute. Lenovo praser does parse this out but there is nowhere to put the value. They did add the column to PhysicalServer and PhysicalSwitch, so I think this was an oversight. pr for switch: ManageIQ/manageiq-schema#160 pr for server: ManageIQ/manageiq-schema@8e95341 Lets add this field back in once it is in the database schema
No PhysicalStorage mention power_state. It is not defined in the schema nor is it a virtual attribute. Lenovo praser does parse this out but there is nowhere to put the value. They did add the column to PhysicalServer and PhysicalSwitch, so I think this was an oversight. pr for switch: ManageIQ/manageiq-schema#160 pr for server: ManageIQ/manageiq-schema@8e95341 Lets add this field back in once it is in the database schema
This PR updates the Switches table and adds the switch id to the hardwares table in order to allow us to parse physical infra switches.