Add lan info to a guest_device (port)

[felipedf]

Adding vlan info to a guest_device when it assume a logical port function

[agrare]

@miq-bot assign @Fryguy

[agrare]

@felipedf could you add a description of what these fields mean? I don't see how they relate to VLANs or how vnicMode is a boolean and not a string.

[felipedf]

@agrare well, now guest_devices can assume a role of a port and a port can have many logical ports, which will also be a guest_device through child_devices field. Supposedly a logical port contains a reference to its vlan and the vnicMode would say whether or not vnic is enabled on this port

[agrare]

@felipedf is this a port on a switch? I wonder if we should add a port model and a switch can have many ports, then a guest_device belongs_to a port?

[agrare]

Spoke offline with @felipedf and this is intended for host NICs not switch ports, and these properties are meant to represent the vlan_id. I recommended just calling it vlan_id and using just one property.

[felipedf]

Spoke with @agrare and decided to keep vlan_id and a vlan_enabled properties, where vlan_enabled is meant to represent the status of a vlan, so a port can be associated to a vlan even though its status is disabled

[rodneyhbrown7]

@agrare @Fryguy can this be merged?

[agrare]

Can you change the name from :vlan_id to something that doesn't end in _id since rails will assume this is a foreign key.
This will represent a physical port on a switch with a tagged vlan.

[felipedf]

Done 😃 👍

[miq-bot]

Checked commit felipedf@d3154c2 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆