Add miq_task_id column to miq_queue table #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to the list of arguments when message deliver. Aslo, it will simplify activating task https://bugzilla.redhat.com/show_bug.cgi?id=1543289
This was referenced Feb 15, 2018
yrudman
changed the title
|
@miq-bot remove-label wip |
|
@miq-bot add-label core, sql migration |
|
@yrudman Cannot apply the following labels because they are not recognized: core, sql migration |
Fryguy
reviewed
Mar 14, 2018
| @@ -0,0 +1,5 @@ | |||
| class LinkQueueAndTask < ActiveRecord::Migration[5.0] | |||
| def change | |||
| add_reference :miq_queue, :miq_task, :type => "bigint", :index => true | |||
There was a problem hiding this comment.
You shouldn't need the explicit :type => "bigint", but I could be wrong. Even so, we should probably use a sybol there instead of a string. Also, not sure on adding an index. @kbrock Thoughts on this index?
There was a problem hiding this comment.
my mistake, we do not need index now.
…umn - access going from queue item to task
|
Checked commits yrudman/manageiq-schema@7aefb23~...0ae2566 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 db/migrate/20180213204846_link_queue_and_task.rb
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linking
miq_queueandmiq_taskstable will:blocking ManageIQ/manageiq#17015
\cc @Fryguy