-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hostname to Vm #168
Add hostname to Vm #168
Conversation
This migration adds attribute `hostname` to `Vm`. For example virtual machine in Vmware provider has attribute computer name and now we will be able to render it into hostname.
cc @miha-plesko |
Checked commit sasoc@ee4da2a with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
I'm not sure I understand why this is being added, since hostnames are already available on Vm. Was this discussed somewhere? I thought on Gitter we already pointed out that where you can see the hostname in the UI. Vm.first.hostnames # => ["windows_2012"] |
@Fryguy I think the problem is two-fold
Currently InfraManagers are just duplicating the one hostname into multiple network records so it doesn't really match either case very well.
Yes it was discussed on gitter I think right after where you pointed out where it is shown in the UI |
@Fryguy we would also need to backport this |
Add hostname to Vm
This migration adds attribute
hostname
toVm
. For examplevirtual machine in Vmware provider has attribute computer name
and now we will be able to render it into hostname.