Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hostname to Vm #168

Merged
merged 1 commit into from
Feb 26, 2018
Merged

Add hostname to Vm #168

merged 1 commit into from
Feb 26, 2018

Conversation

sasoc
Copy link
Contributor

@sasoc sasoc commented Feb 15, 2018

This migration adds attribute hostname to Vm. For example
virtual machine in Vmware provider has attribute computer name
and now we will be able to render it into hostname.

This migration adds attribute `hostname` to `Vm`. For example
virtual machine in Vmware provider has attribute computer name
and now we will be able to render it into hostname.
@sasoc
Copy link
Contributor Author

sasoc commented Feb 15, 2018

cc @miha-plesko

@miq-bot
Copy link
Member

miq-bot commented Feb 15, 2018

Checked commit sasoc@ee4da2a with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@miha-plesko
Copy link
Contributor

@miq-bot assign @agrare
@miq-bot add_label enhancement

/cc @Ladas

@Fryguy
Copy link
Member

Fryguy commented Feb 16, 2018

I'm not sure I understand why this is being added, since hostnames are already available on Vm. Was this discussed somewhere? I thought on Gitter we already pointed out that where you can see the hostname in the UI.

Vm.first.hostnames # => ["windows_2012"]

@agrare
Copy link
Member

agrare commented Feb 16, 2018

@Fryguy I think the problem is two-fold

  1. Cloud VMs don't have hardware.networks so they don't have that option
  2. A machine can only have one "hostname", the rest are DNS records that aren't really modeled well currently e.g. there can only be one hostname per ip address.

Currently InfraManagers are just duplicating the one hostname into multiple network records so it doesn't really match either case very well.

Was this discussed somewhere

Yes it was discussed on gitter I think right after where you pointed out where it is shown in the UI

@miha-plesko
Copy link
Contributor

@Fryguy we would also need to backport this vm.hostname field to GA by means of reserved table, so I kindly ask to push this PR forward.

@agrare
Copy link
Member

agrare commented Feb 22, 2018

@miq-bot assign @Fryguy

@miq-bot miq-bot assigned Fryguy and unassigned agrare Feb 22, 2018
@Fryguy Fryguy merged commit b67301c into ManageIQ:master Feb 26, 2018
@Fryguy Fryguy added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 26, 2018
@Fryguy Fryguy added the schema label Feb 26, 2018
douglasgabriel pushed a commit to douglasgabriel/manageiq-schema that referenced this pull request Mar 19, 2018
@djberg96
Copy link
Contributor

@sasoc @Fryguy @agrare I'm late to the party, but I would love a comment added to this field. I put a lot of work into that! #297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants