Add index on STI type columns #190
Conversation
This follows on from pervious work in this PR ManageIQ/manageiq#9516
|
@miq-bot add_label performance "sql migration" wip |
|
@juliancheal Cannot apply the following label because they are not recognized: performance "sql migration" wip |
juliancheal
changed the title
|
Looks like there are a few tables that don't exist anymore. Will update PR. |
juliancheal
force-pushed
the
add_missing_indexes_to_type_colums
branch
from
50f38d9 to
6fa4519
Compare
|
Seems ok to me. @kbrock Thoughts? |
juliancheal
changed the title
|
I had thought we may want to make compound indexes out of these instead of just |
|
@kbrock what's a compound index? |
| add_index :dialog_fields, :type | ||
| add_index :ems_clusters, :type | ||
| add_index :ems_folders, :type | ||
| add_index :event_streams, :type |
There was a problem hiding this comment.
Lets not add an index to event_streams unless we know it is needed for an index.
This table is BIG
There was a problem hiding this comment.
Removed event_streams
juliancheal
force-pushed
the
add_missing_indexes_to_type_colums
branch
from
6fa4519 to
ff84d67
Compare
|
@Fryguy merge on 🍏 ? |
|
Checked commits juliancheal/manageiq-schema@fc898fc~...ff84d67 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
This follows on from pervious work in this PR ManageIQ/manageiq#9516
I created this as a new migration and not a cherry-pick to give us an updated timestamp.
/cc @Fryguy @kbrock