Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding column on physical_network_ports table to connect other ports #208

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

douglasgabriel
Copy link
Member

This PR is able to

  • Add the connected_port_uid column to set the uid_ems of the connected port;

Goal
A physical network port should know to who it is connected, so it have a bidirectional one to one relationship:
image

Verified

This commit was signed with the committer’s verified signature.
@miq-bot
Copy link
Member

miq-bot commented May 29, 2018

Checked commit douglasgabriel@a6a7d11 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@douglasgabriel
Copy link
Member Author

@miq-bot add_reviewer @agrare
@miq-bot assign @Fryguy

@miq-bot miq-bot requested a review from agrare May 30, 2018 12:04
@agrare
Copy link
Member

agrare commented Jun 19, 2018

@Fryguy looks good to me, tested with ManageIQ/manageiq#17311 applied and the link between physical_network_ports works 👍

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @Fryguy can you merge if you're ok with this? Thanks.

@Fryguy Fryguy merged commit 22f432a into ManageIQ:master Jun 21, 2018
@Fryguy Fryguy added this to the Sprint 89 Ending Jul 2, 2018 milestone Jun 21, 2018
bdunne added a commit to bdunne/manageiq-schema that referenced this pull request Jul 9, 2019

Verified

This commit was signed with the committer’s verified signature.
carbonin added a commit that referenced this pull request Jul 9, 2019

Verified

This commit was signed with the committer’s verified signature.
Fix whitespace after linux_admin #208
simaishi pushed a commit that referenced this pull request Jul 12, 2019
Fix whitespace after linux_admin #208

(cherry picked from commit 70ea267)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants