Convert user quadicon settings from the old format to the new one #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
force-pushed
the
convert-quadicon-settings
branch
2 times, most recently
from
a496eda to
294628a
Compare
lpichler
reviewed
Jun 6, 2018
| user.reload | ||
|
|
||
| expect(user.settings[:quadicons][:ems_infra]).to be_nil | ||
| expect(user.settings[:quadicons][:ems]).to eq(false) |
There was a problem hiding this comment.
do we have matcher for it ? like be_falsey or something like that ?
skateman
force-pushed
the
convert-quadicon-settings
branch
from
294628a to
7d9efaa
Compare
|
Checked commit skateman@7d9efaa with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new quadicon settings logic requires to move the value from
settings[:quadicons][:ems]into settings[:quadicons][:ems_infra] for each user.Parent issue: ManageIQ/manageiq-ui-classic#4027