Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archive Container Nodes #22

Merged
merged 1 commit into from
Jul 3, 2017
Merged

Archive Container Nodes #22

merged 1 commit into from
Jul 3, 2017

Conversation

zakiva
Copy link
Contributor

@zakiva zakiva commented Jun 25, 2017 •
edited
Loading

Adding deleted_on and old_ems_id columns to container_nodes table.
Extracted from ManageIQ/manageiq#15351.

@simon3z @moolitayer

@zakiva zakiva mentioned this pull request Jun 25, 2017
Merged
@miq-bot
Copy link
Member

miq-bot commented Jun 25, 2017

Checked commit zakiva@d5c95f4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@zakiva
Copy link
Contributor Author

zakiva commented Jun 25, 2017

@miq-bot add_label providers/containers, enhancement

@miq-bot
Copy link
Member

miq-bot commented Jun 25, 2017

@zakiva Cannot apply the following label because they are not recognized: providers/containers

moolitayer
moolitayer approved these changes Jun 25, 2017
View reviewed changes
Copy link

@moolitayer moolitayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
cc @Fryguy

@cben cben mentioned this pull request Jun 25, 2017
Merged
@Fryguy
Copy link
Member

Fryguy commented Jul 3, 2017

@Ladas I am merging this, so wanted to give you a heads up that this may affect #18 .

@Fryguy Fryguy merged commit dad5bf2 into ManageIQ:master Jul 3, 2017
@Fryguy Fryguy added this to the Sprint 64 Ending Jul 3, 2017 milestone Jul 3, 2017
@Fryguy Fryguy self-assigned this Jul 3, 2017
@cben cben mentioned this pull request Aug 22, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moolitayer moolitayer moolitayer approved these changes

Assignees

@Fryguy Fryguy

Labels
enhancement schema
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zakiva @miq-bot @Fryguy @moolitayer @chessbyte