Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the quadicon settings migration for users without quadicon settings #225

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

skateman
Copy link
Member

As we discussed with @Fryguy and reported by @branic the migration can fail if the :quadicons key isn't available in the User#settings hash. This simple one-liner fixes the problem by skipping to migrate the affected users.

@miq-bot add_label bug, gaprindashvili/no
@miq-bot assign @Fryguy

@skateman skateman force-pushed the quadicon-migration-fix branch from f9d1043 to 567d11a Compare June 22, 2018 07:50
@miq-bot
Copy link
Member

miq-bot commented Jun 22, 2018

Checked commit skateman@567d11a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@Fryguy Fryguy merged commit 281415d into ManageIQ:master Jun 22, 2018
@Fryguy Fryguy added this to the Sprint 89 Ending Jul 2, 2018 milestone Jun 22, 2018
@skateman skateman deleted the quadicon-migration-fix branch June 22, 2018 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants