Adding Location LED name to asset_details table

[douglasgabriel]

It is required to send LED action to physical components, once that the name of the LED can vary to each component.

[douglasgabriel]

@miq-bot assign @agrare

[agrare]

@douglasgabriel I'd recommend calling this something other than _name, it sounds like this is more of a unique identifier sent to the API to target a specific LED which we would call an _ems_ref.

xClarity may use a name for this but other physical providers might use something else.

[douglasgabriel]

Good point @agrare. Updated.

[agrare]

@miq-bot assign @Fryguy

[miq-bot]

Checked commit douglasgabriel@5f703b0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

[Fryguy]

In general I'm ok with this, but I'm curious why this is not a foreign key reference to the table with the location_led itself instead?

[douglasgabriel]

Do we have a table for location_led? What we do today is parse just the location led state into the component table (ex: physical_servers). The idea to parse the location_led_ems_ref inside the asset_details table is to share this column with all physical components avoiding to put this column on each component table.

[Fryguy]

Discussed with @douglasgabriel and the long term goal is to put location_led_status into asset_details, so that should keep them together and consistent, so I am good with this. 👍