Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add internal column to ServiceTemplate table #238

Merged
merged 6 commits into from
Aug 9, 2018
Merged

Add internal column to ServiceTemplate table #238

merged 6 commits into from
Aug 9, 2018

Conversation

hsong-rh
Copy link
Contributor

Add a internal column in ServiceTemplate table to mark its accessible scope.

https://bugzilla.redhat.com/show_bug.cgi?id=1594408

@hsong-rh
Copy link
Contributor Author

This is related with PR ManageIQ/manageiq#17681

@bzwei @gmcculloug Please review.

@bzwei
Copy link
Contributor

bzwei commented Jul 19, 2018

LGTM

@gmcculloug
Copy link
Member

@miq-bot add_label transformation
@miq-bot assign @Fryguy

@hsong-rh
Copy link
Contributor Author

hsong-rh commented Jul 20, 2018 •
edited
Loading

include ReservedMixin
reserve_attribute :internal, :boolean
need to be added in ServiceTemplate to pass CI build.

@bthurber
Copy link

@gmcculloug any remaining items left to merge?

@gmcculloug gmcculloug mentioned this pull request Jul 23, 2018
Merged
@gmcculloug
Copy link
Member

@bthurber I do not have permission to merge on this repo.

@Fryguy Please review.

bzwei
bzwei reviewed Jul 24, 2018
View reviewed changes
spec/migrations/20180719163110_add_internal_to_service_template_spec.rb Outdated
let(:service_template_stub) { migration_stub(:ServiceTemplate) }

migration_context :up do
it "migrate reserve data to ServiceTemplate" do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case without reserved data but with ServiceTemplateTransformationPlan type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@hsong-rh hsong-rh mentioned this pull request Jul 24, 2018
Merged
@miq-bot
Copy link
Member

miq-bot commented Jul 24, 2018

Checked commits hsong-rh/manageiq-schema@74a8eda~...89b60c3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

db/migrate/20180719163110_add_internal_to_service_template.rb

@JPrause
Copy link
Member

JPrause commented Jul 31, 2018

@miq-bot add_label blocker

@JPrause
Copy link
Member

JPrause commented Jul 31, 2018

@hsong-rh if this can be backported, can you add the gaprindashvili/yes label.

@gmcculloug
Copy link
Member

@JPrause We do not back-port schema changes.

The work for the BZ in the description, that will be back-ported, is in ManageIQ/manageiq#17748 and is already properly labeled. This PR is related to that work but is intended for upstream only.

@hsong-rh hsong-rh mentioned this pull request Jul 31, 2018
Merged
@gmcculloug
Copy link
Member

@Fryguy Please review

@Fryguy Fryguy merged commit 332cd7c into ManageIQ:master Aug 9, 2018
@Fryguy Fryguy added this to the Sprint 92 Ending Aug 13, 2018 milestone Aug 9, 2018
@gmcculloug gmcculloug mentioned this pull request Aug 10, 2018
Merged
@bdunne bdunne removed the blocker label Aug 13, 2018
@Fryguy Fryguy added v2v and removed transformation labels Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzwei bzwei bzwei left review comments

@gmcculloug gmcculloug gmcculloug approved these changes

Assignees

@Fryguy Fryguy

Labels
data schema v2v
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@hsong-rh @bzwei @gmcculloug @bthurber @miq-bot @JPrause @Fryguy @bdunne