Add link_to field on notification_types table to point to a binding #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
changed the title
skateman
force-pushed
the
notification-type-link
branch
from
81ce65b
to
b68dd49
Compare
skateman
changed the title
|
Checked commit skateman@b68dd49 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
skateman
changed the title
|
Looks good to me! Ping @agrare |
martinpovolny
approved these changes
Aug 28, 2018
carbonin
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 3 bindings on a notification that can have links (initiator, subject, cause). This extra field allows the notification type creators to use one of them as a link to the notification details.
Related issue: ManageIQ/manageiq-v2v#578
Backend: ManageIQ/manageiq#17913
UI part: ManageIQ/manageiq-ui-classic#4492
ping @martinpovolny @AparnaKarve