Add parent physical chassis id to physical chassis #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
reviewed
Aug 30, 2018
| @@ -0,0 +1,17 @@ | |||
| require_migration | |||
There was a problem hiding this comment.
we don't need specs for structural migrations, they are tested by rails's specs, we need it only for migration with data manipulation, so you can remove it, thanks!
tadeboro
force-pushed
the
add-physical-chassis-hierarchy-field
branch
2 times, most recently
from
df4f246
to
b7a3e10
Compare
This additional field is used to model chassis nesting, for example rack containing multiple enclosures that in turn contain multiple sleds, containing one or more physical servers.
tadeboro
force-pushed
the
add-physical-chassis-hierarchy-field
branch
from
b7a3e10
to
7142dd2
Compare
|
Checked commit xlab-si@7142dd2 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@lpichler Thanks for your input. I removed the unnecessary tests as suggested. |
agrare
approved these changes
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This additional field is used to model chassis nesting. Example would be installation that uses Intel's Rack Scale Design (pod containing multiple racks containing multiple blocks that in turn contain multiple sleds ...).