Add limits colums to conversion_hosts table #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
requested changes
Sep 17, 2018
carbonin
reviewed
Sep 17, 2018
| class AddConversionHostLimitsColumns < ActiveRecord::Migration[5.0] | ||
| def change | ||
| change_table :conversion_hosts do |t| | ||
| t.string :limits_max_concurrent_transformations |
There was a problem hiding this comment.
I'm not sure about the naming and plualization here, also limit + max seems redundant. Wouldn't this be clearer as concurrent_transformation_limit?
| def change | ||
| change_table :conversion_hosts do |t| | ||
| t.string :limits_max_concurrent_transformations | ||
| t.string :limits_max_cpu |
There was a problem hiding this comment.
Same for these, I think they would read better as <metric>_limit or max_used_<metric>.
Also, just for my own curiosity, are these metrics on the conversion host or limits on the VMs this host can convert?
ghost
force-pushed
the
v2v_add_conversion_host_limits
branch
from
c3e5c6c
to
5070b58
Compare
|
Checked commit fabiendupont@5070b58 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@agrare Commit squashed. |
agrare
approved these changes
Sep 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds colums to model V2V throttling limits at conversion host level.